Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.12 and run terminator search cv #264

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jun 6, 2024

Motivation

#230 and run a sklearn search cv by the CI.

Description of the changes

  • Add python 3.12
  • Run terminator_search_cv.py

Comment on lines 37 to +39
python terminator/terminator_improvement_plot.py
python terminator/terminator_search_cv.py
python terminator/terminator_simple.py
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetical order

@nzw0301
Copy link
Member Author

nzw0301 commented Jun 6, 2024

I'm not sure why the skelarn's counter example script: https://github.com/optuna/optuna-examples/blob/main/sklearn/sklearn_optuna_search_cv_simple.py, is not executed by the CI job. Maybe additional pandas dependency?

@nabenabe0928
Copy link
Collaborator

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, LGTM!

@nabenabe0928 nabenabe0928 merged commit 7450fbd into optuna:main Jun 12, 2024
13 checks passed
@nzw0301 nzw0301 deleted the terminator-312 branch June 12, 2024 02:16
@not522 not522 added this to the v4.0.0 milestone Jul 3, 2024
@nzw0301 nzw0301 added the CI Continuous integration. label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants